Re: [Xen-devel] [PATCH] x86emul: minor cleanup

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 08/06/17 16:49, Jan Beulich wrote:
> Drop a redundant input constraint, correct a comment, and (re)move
> fix.insn_bytes adjustments (these aren't needed for custom stub
> invocations when the instruction placed in the stub can't raise #XF)

I'm not sure these are wise to remove.  Even if we don't expect an
exception, should one occur, fpu_handle_exception() will fail to step
over the instruction, and will re-execute it.

~Andrew

> plus a corresponding check_xmm_exn() invocation.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel