Re: [Xen-devel] [PATCH LIVEPATCH-BUILD-TOOLS 2/2] Remove section alignment requirement

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Fri, Jun 09, 2017 at 06:00:35PM +0100, Andrew Cooper wrote:
> On 09/06/17 17:38, Konrad Rzeszutek Wilk wrote:
> > On Fri, Jun 09, 2017 at 05:03:36PM +0100, Ross Lagerwall wrote:
> >> Remove the requirement that section twins have the same alignment. The
> >> section alignment of the patched section is respected by the loader in
> >> Xen so it shouldn't matter if the original section alignment was
> >> different.
> > Why would we have different section aligment for the same twins?
> >
> > I understand the change here - if for example the original code
> > had:
> >
> >  .rodata.str.1
> >
> > [I think I got the section name right - that should be a string
> > generated with 1 byte alignment, say 'a'].
> >
> > But the new patch has a new one:
> >
> >  .rodata.str.2
> >
> > ['a' -> 'ab']
> >
> > Is that what we are fixing here?
> 
> Functions also have alignment.  For reasons best known to the compiler,
> the fix for XSA-213 caused the alignment of arch_do_multicall_call() to
> change from 1 to 16.

OK, could this be please be included in the commit description?

And with Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

Ross,  you ok committing it in livepatch-build-tools.git? Thanks!
> 
> The build tools choked on this, but the result is legitimate, and did
> work fine.
> 
> ~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel