Re: [Xen-devel] [PATCH 02/14 v4] xen/arm: vpl011: Define generic vreg_reg* access functions in vreg.h

[Julien Grall <julien.grall@xxxxxxx>]

Hi Bhupinder,

On 06/06/17 18:25, Bhupinder Thakur wrote:
> -/* N-bit register helpers */
> -#define VGIC_REG_HELPERS(sz, offmask)                                   \
> -static inline register_t vgic_reg##sz##_extract(uint##sz##_t reg,       \
> -                                                const mmio_info_t *info)\
[...]

> +#define VREG_REG_HELPERS(sz, offmask)                                          
>  \
> +/* N-bit register helpers */                                                   
>  \
> +static inline register_t vreg_reg##sz##_extract(uint##sz##_t reg,              
>  \
> +                                                  const mmio_info_t *info)     
>  \
Please don't modify the indentation. There is no reason to do that and 
make the review more difficult to do. This patch should *only* replace 
vgic by vreg.
> @@ -211,10 +211,9 @@ static inline void vgic_reg##sz##_clearbits(uint##sz##_t 
> *reg,          \
>   * unsigned long rather than uint64_t
>   */
>  #if BITS_PER_LONG == 64
> -VGIC_REG_HELPERS(64, 0x7);
> +VREG_REG_HELPERS(64, 0x7);
>  #endif
> -VGIC_REG_HELPERS(32, 0x3);
> -
Why did you drop this line?

> -#undef VGIC_REG_HELPERS
> +VREG_REG_HELPERS(32, 0x3);
> +#undef VREG_REG_HELPERS
>
>  #endif /* __ASM_ARM_VREG__ */
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel