Re: [Xen-devel] [PATCH 05/15] xen: make it possible to disable tracing in Kconfig.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.06.17 at 17:37, <george.dunlap@xxxxxxxxxx> wrote:
> On 08/06/17 16:35, Jan Beulich wrote:
>>>>> On 08.06.17 at 17:16, <george.dunlap@xxxxxxxxxx> wrote:
>>> On 07/06/17 16:14, Jan Beulich wrote:
>>>>>>> On 01.06.17 at 19:34, <dario.faggioli@xxxxxxxxxx> wrote:
>>>>> --- a/xen/Kconfig.debug
>>>>> +++ b/xen/Kconfig.debug
>>>>> @@ -98,6 +98,14 @@ config PERF_ARRAYS
>>>>>   ---help---
>>>>>     Enables software performance counter array histograms.
>>>>>  
>>>>> +config TRACING
>>>>> + bool "Tracing"
>>>>> + default y
>>>>
>>>> default DEBUG (you don't want to suggest turning it on for a
>>>> release build)
>>>
>>> In the past I've found it pretty useful to have on in release builds of
>>> XenServer, to analyze performance problems a customer was having, and
>>> sometimes to see where the guest was crashing.
>> 
>> Well, that's your choice. I'm only asking to default to off in release
>> builds, not to prevent enabling it.
> 
> Of course; the question is, as you say, what we're "suggesting"; and
> what people will experience if they just go with the default.
> 
> If it were up to me I'd leave it on by default, but I don't have a
> strong opinion.

If you look at that section in Kconfig.debug, nothing defaults to
y, and I think this is appropriate for debug options in general. I
additionally think that defaults suggested in EXPERT mode should
match the values automatically chosen in non-EXPERT mode.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel