[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 02/15] xen: tracing: avoid checking tb_init_done multiple times.

To: Dario Faggioli <dario.faggioli@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
From: George Dunlap <george.dunlap@xxxxxxxxxx>
Date: Thu, 8 Jun 2017 15:37:06 +0100
Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
Delivery-date: Thu, 08 Jun 2017 14:37:15 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 01/06/17 18:33, Dario Faggioli wrote:
> In fact, when calling __trace_var() directly, we can
> assume that tb_init_done has been checked to be true,
> and the if is hence redundant.

You probably want to adjust the comment before the smp_rmb() that
mentions tb_init_done as well.

Other than that, looks good.

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

References:
- [Xen-devel] [PATCH 00/15] xen/tools: add tracing to various Xen subsystems
  - From: Dario Faggioli
- [Xen-devel] [PATCH 02/15] xen: tracing: avoid checking tb_init_done multiple times.
  - From: Dario Faggioli

Prev by Date: Re: [Xen-devel] [PATCH 02/15] xen: tracing: avoid checking tb_init_done multiple times.
Next by Date: Re: [Xen-devel] [PATCH 01/15] xen: in do_softirq() sample smp_processor_id() once and for all.
Previous by thread: Re: [Xen-devel] [PATCH 02/15] xen: tracing: avoid checking tb_init_done multiple times.
Next by thread: [Xen-devel] [PATCH 03/15] xen/tools: tracing: several improvements on IRQs tracing
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.