Re: [Xen-devel] [Qemu-devel] [PATCH v2 11/14] char: move CharBackend handling in char-fe unit

[Marc-André Lureau <marcandre.lureau@xxxxxxxxx>]

Hi

On Wed, Jun 7, 2017 at 8:57 PM Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:

On Mon, May 29, 2017 at 12:45:43PM +0400, Marc-André Lureau wrote:
> Move all the fronted struct and methods to a seperate unit. This avoids
> accidentally mixing backend and frontend calls, and helps with readibilty.
>
> Make qemu_chr_replay() a macro shared by both char and char-fe.
>
> Export qemu_chr_write(), and use a macro for qemu_chr_write_all()
>
> (nb: yes, CharBackend is for char frontend :)

Hi Marc-André,

Following this patch, we are not able anymore to launch QEMU with
-monitor /dev/null.
> qemu-system-i386: -monitor /dev/null: 'tty' is not a valid char driver name

FYI, the full command line used:
/usr/lib/xen/bin/qemu-system-i386 -xen-domid 0 \
    -xen-attach -name dom0 -nographic -M xenpv -daemonize \
    -monitor /dev/null -serial /dev/null -parallel /dev/null \
    -nodefaults -no-user-config \
    -pidfile /var/run/xen/qemu-dom0.pid

My bad, and the worse is that CI actually gave me some hints of the regression because the ChardevAlias array was empty.

I dropped char-serial.h and char-parellel.h in this patch, it shouldn't be. I'll send fixes and add some tests.

Thanks for the report!

--

Marc-André Lureau

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel