Re: [Xen-devel] [PATCH] RFC x86/emul: Drop segment_attributes_t

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.06.17 at 17:44, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 07/06/17 14:40, Jan Beulich wrote:
>>>>> On 07.06.17 at 15:04, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> Furthermore, in a following patch, I intend to make a similar adjustment as
>>> http://xenbits.xen.org/gitweb/?p=xtf.git;a=commitdiff;h=f099211f2ebdadf61ae6
>>>  
>>> 416559220d69b788cd2b
>>> to expose the internal code/data field names.  This will simplify a lot of
>>> code which currently uses opencoded numbers against the type field.
>> This is nice too, with two caveats: The "a" bit is not code
>> segment specific (but placed so)
> 
> Least bad option I'm afraid.  It can't live in the common struct because
> it is part of the type nibble, and it can't live in both the code and
> data anonymous unions because it has the same name.

It could be put in a 3rd struct, but I guess that's more extra
overhead than actual gain.

>>  and the "x" bit is an invention
>> of yours afaict, which I'd prefer to be e.g. "code".
> 
> It is the eXecutable bit.  I got the terminology from one of the two
> manuals, but don't recall exactly where.

Oh, okay. I don't recall running across this.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel