Re: [Xen-devel] [PATCH v10 06/32] ARM: GIC: Add checks for NULL pointer pending_irq's

[Julien Grall <julien.grall@xxxxxxx>]

On 06/06/17 11:19, Andre Przywara wrote:
> Hi,
>
> On 30/05/17 12:38, Julien Grall wrote:
> > Hi Andre,
> >
> > On 26/05/17 18:35, Andre Przywara wrote:
> > > For LPIs the struct pending_irq's are dynamically allocated and the
> > > pointers will be stored in a radix tree. Since an LPI can be "unmapped"
> > > at any time, teach the VGIC how to deal with irq_to_pending() returning
> > > a NULL pointer.
> > > We just do nothing in this case or clean up the LR if the virtual LPI
> > > number was still in an LR.
> > >
> > > Those are all call sites for irq_to_pending(), as per:
> > > "git grep irq_to_pending", and their evaluations:
> > > (PROTECTED means: added NULL check and bailing out)
> > >
> > >     xen/arch/arm/gic.c:
> > > gic_route_irq_to_guest(): only called for SPIs, added ASSERT()
> > > gic_remove_irq_from_guest(): only called for SPIs, added ASSERT()
> > > gic_remove_from_queues(): PROTECTED, called within VCPU VGIC lock
> > This function has been renamed in patch #4.
> >
> > > gic_raise_inflight_irq(): PROTECTED, called under VCPU VGIC lock
> > > gic_raise_guest_irq(): PROTECTED, called under VCPU VGIC lock
> > > gic_update_one_lr(): PROTECTED, called under VCPU VGIC lock
> > >
> > >     xen/arch/arm/vgic.c:
> > > vgic_migrate_irq(): not called for LPIs (virtual IRQs), added ASSERT()
> > > arch_move_irqs(): not iterating over LPIs, added ASSERT()
> > I don't see any ASSERT added in arch_move_irqs.
> Because this is just checking for not being called with an LPI, it was
> introduced in patch 03/32 already. I can adjust the commit message.
Yes please.

> Cheers,
> Andre.
>
> > > vgic_disable_irqs(): not called for LPIs, added ASSERT()
> > > vgic_enable_irqs(): not called for LPIs, added ASSERT()
> > > vgic_vcpu_inject_irq(): PROTECTED, moved under VCPU VGIC lock
> > >
> > >     xen/include/asm-arm/event.h:
> > > local_events_need_delivery_nomask(): only called for a PPI, added
> > > ASSERT()
> > >
> > >     xen/include/asm-arm/vgic.h:
> > > (prototype)
> > Cheers,
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel