[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86: partially undo "fix build with gcc 7"



Hi,

On 01/06/17 12:14, Jan Beulich wrote:
On 01.06.17 at 13:06, <julien.grall@xxxxxxx> wrote:
On 31/05/17 08:51, Jan Beulich wrote:
While f32400e90c ("x86: fix build with gcc 7")'s change to
compat_array_access_ok() is necessary, I had blindly and needlessly
also added it to array_access_ok(). There's no conditional expression
involved there, so undo it.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---
No ARM counterpart, as Julien means to remove the macro anyway.

To double-check, I am CCed on this e-mail because you would like this
patch in Xen 4.9, right?

No, because of the "No ARM counterpart ..." remark. Of course
I wouldn't mind this going into 4.9, but I did specifically not submit
the patch before branching because the code as is will do there. I
simply didn't want to leave this in place for the longer term.

Oh. Yes the patch has been sent and acked by Stefano. Hopefully it will get merged soon.

Regarding the patch, I would avoid to add it in Xen 4.9 if it is not fixing a regression/critical bug.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.