[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/4] SVM: clean up svm_vmcb_dump()

>>> On 31.05.17 at 13:34, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 31/05/17 08:22, Jan Beulich wrote:
>> - constify parameter
>> - use accessors
>> - drop stray casts
>> - adjust formatting
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Given the const, why switch to using accessors?  There are no issues
> with cleanbits.

I consider it wrong to open code things which have accessors.
Otherwise you could ask why there are "get" accessors at all.
Also the nice thing about using them is that they'll hide the
otherwise ugly (imo) leading underscores of the field names.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.