Re: [Xen-devel] [PATCH for-next v3 10/22] x86/traps: delcare percpu softirq_trap

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, May 29, 2017 at 09:49:47AM -0600, Jan Beulich wrote:
> >>> On 18.05.17 at 19:09, <wei.liu2@xxxxxxxxxx> wrote:
> > It needs to be non-static when we split PV specific code out.
> 
> I don't follow here: The variable is used by send_guest_trap() to
> communicate with its helper nmi_mce_softirq(). How would you
> move one without the other?

I chose to not move nmi_mce_softirq, which is needed by trap_init, hence
this patch.

Your suggestion will require nmi_mce_softirq to be exported via a header
(and possibly prefix with pv_). I'm fine with that, too.

> The main cleanup potential I see
> here would be for the struct softirq_trap to be moved from the
> header to the C file (as it's used in only one of them).
> 
> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel