[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v7] ns16550: Add support for UART parameters to be specifed with name-value pairs

Hi Jan,

On 05/31/2017 10:23 AM, Jan Beulich wrote:
On 10.05.17 at 18:20, <swapnil.paratey@xxxxxxx> wrote:
Add name=value parsing options for com1 and com2 to add flexibility
in setting register values for MMIO UART devices.

Maintain backward compatibility with previous positional parameter

eg. com1=115200,8n1,0x3f8,4
eg. com1=115200,8n1,0x3f8,4,reg_width=4,reg_shift=2
eg. com1=baud=115200,parity=n,reg_width=4,reg_shift=2,irq=4

Signed-off-by: Swapnil Paratey <swapnil.paratey@xxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

So you may have noticed that I did commit this, but then I had to
revert it again, as it breaks the build on ARM. Didn't you need the
change specifically for ARM? If so, how come you didn't build test
it there?

I would be surprised if this change is necessary for ARM as we don't support com1.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.