Re: [Xen-devel] [RFC PATCH V2 11/26] x86/hvm: Introduce a emulated VTD for HVM

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 30.05.17 at 17:36, <wei.liu2@xxxxxxxxxx> wrote:
> On Thu, May 18, 2017 at 01:34:41AM -0400, Lan Tianyu wrote:
>> --- a/xen/arch/x86/hvm/Makefile
>> +++ b/xen/arch/x86/hvm/Makefile
>> @@ -22,6 +22,7 @@ obj-y += rtc.o
>>  obj-y += save.o
>>  obj-y += stdvga.o
>>  obj-y += vioapic.o
>> +obj-y += vvtd.o
> 
> Please sort this.

Also I guess this belongs into vmx/ ?

>> --- /dev/null
>> +++ b/xen/arch/x86/hvm/vvtd.c
>> @@ -0,0 +1,176 @@
>> +/*
>> + * vvtd.c
>> + *
>> + * virtualize VTD for HVM.
>> + *
>> + * Copyright (C) 2017 Chao Gao, Intel Corporation.
>> + *
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms and conditions of the GNU General Public
>> + * License, version 2, as published by the Free Software Foundation.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> + * General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU General Public
>> + * License along with this program; If not, see 
>> <http://www.gnu.org/licenses/>.
>> + */
>> +
>> +#include <xen/domain_page.h>
>> +#include <xen/sched.h>
>> +#include <xen/types.h>
>> +#include <xen/viommu.h>
>> +#include <xen/xmalloc.h>
>> +#include <asm/current.h>
>> +#include <asm/hvm/domain.h>
>> +#include <asm/page.h>
>> +#include <public/viommu.h>
>> +
>> +#include "../../../drivers/passthrough/vtd/iommu.h"
>> +
> 
> Maybe you should move this header to include/asm-x86?

Or, other than suggested above, the .c file should move into
that directory?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel