Re: [Xen-devel] [PATCH 03/12 v3] xen/arm: vpl011: Add pl011 uart emulation in Xen

[Julien Grall <julien.grall@xxxxxxx>]

On 05/29/2017 08:13 AM, Bhupinder Thakur wrote:
> Hi Julien,
Hi Bhupinder,

> On 26 May 2017 at 19:12, Bhupinder Thakur <bhupinder.thakur@xxxxxxxxxx> wrote:
> > > > +#ifndef _VPL011_H_
> > > > +
> > > > +#define _VPL011_H_
> > > > +
> > > > +#include <public/io/ring.h>
> > > > +#include <asm-arm/vreg.h>
> > > > +
> > > > +DEFINE_XEN_FLEX_RING(vpl011);
> > >
> > > I am sure someone already said it in a previous version. The vpl011 is the
> > > console ring. So why are we defining our own internally?
> This macro only defines standard functions to operate on the console
> ring. Stefano suggested to use the standard functions to operate on
> the ring buffer.
I don't want things to be mixed up like that, this is a call to trouble 
later on if someone decide to update console.h.
If you need to introduce standard functions, they should be defined in 
console.h and not vpl011.h.
> > > At least this should have been used by xenconsole, but this is not the
> > > case... So we should really avoid defining our own ring here and re-use
> > > public/io/console.h.
> I am using the console ring definition as defined in
> xen/include/public/io/console.h.
See above.

Cheers,

--
Julien Grall


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel