Re: [Xen-devel] [OSSTEST PATCH 06/24] cs-hosts-list: New utility

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Tue, May 23, 2017 at 02:54:16PM +0100, Ian Jackson wrote:
> Roger Pau Monné writes ("Re: [Xen-devel] [OSSTEST PATCH 06/24] cs-hosts-list: 
> New utility"):
> > On Thu, May 18, 2017 at 12:01:16PM +0100, Ian Jackson wrote:
> > > +foreach my $flag (grep { length} split /\,/, $flags) {
> > > +    $qtxt.= <<END;
> > > +    AND EXISTS (SELECT 1 FROM HOSTFLAGS f
> > > +                        WHERE resname=f.hostname
> > > +                          AND f.hostflag=?)
> > 
> > There seems to be a mix between hard tabs and spaces above.
> 
> Indeed.  Does that bother you ?  osstest is full of that and it
> doesn't bothere me...

Not really, but for new scripts I've tried to keep a more uniform style,
although vim was very confused about whether it should use hard tabs or spaces
:).

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel