[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [OSSTEST PATCH 03/24] cs-flight-create: Fix usage error message



On Thu, May 18, 2017 at 12:01:13PM +0100, Ian Jackson wrote:
> This spuriously prints $!.  It's still a poor message.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> ---
>  cs-flight-create | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cs-flight-create b/cs-flight-create
> index a412396..dc61e62 100755
> --- a/cs-flight-create
> +++ b/cs-flight-create
> @@ -24,7 +24,7 @@ use Osstest;
>  
>  csreadconfig();
>  
> -@ARGV==2 or die $!;
> +@ARGV==2 or die;

Maybe a "Invalid number of arguments provided, expected 2"?

In any case:

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.