Re: [Xen-devel] [resend PATCH] xen: common: rbtree: ported updates from linux tree

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.05.17 at 11:12, <kpraveen.lkml@xxxxxxxxx> wrote:
> On Thu, 2017-05-18 at 16:47 +0200, Dario Faggioli wrote:
>> On Thu, 2017-05-18 at 07:59 -0600, Jan Beulich wrote:
>> > 
>> > > 
>> > > > 
>> > > > > 
>> > > > > On 11.05.17 at 19:21, <kpraveen.lkml@xxxxxxxxx> wrote:
>> > > 
>> > > The patch contains the updated version of rbtree implementation
>> > > from linux
>> > > kernel tree containing the fixes so far handled.
>> > 
>> > I suppose this isn't just fixes, but also enhancements. Furthermore
>> > I'd appreciate if you recorded the Linux version this was taken
>> > from,
>> > so that anyone wanting to do another upgrade would know what
>> > the baseline is. In any event, as long as this is just a general
>> > overhaul and upgrade, I'd like to either see individual bugs
>> > pointed
>> > out which get fixed _and_ which affect us, or I'd expect this to be
>> > part of a series which actually requires some of the new
>> > functionality.
>> > 
>> I fully agree.
> 
> Sure, will put the the commit text ? Else, is it fine to put in as a
> code comment ?

Code comment? The intention has to be to take the Linux code
with as little changes as possible. That includes not adding
comments which don't exist in the original. So unless you follow
Dario's suggestion to possibly use individual Linux commits
instead of this giant one, it'll be the commit message where all
this information should go.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel