Re: [Xen-devel] [PATCH 3/3] arm: fix build with gcc 7

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 18/05/17 09:41, Jan Beulich wrote:
> The compiler dislikes duplicat "const", and the ones it complains about
s/duplicat/duplicate/

> look like they we in fact meant to be placed differently.
>
> Also fix array_access_okay() (just like on x86), despite the construct
> being unused on ARM: -Wint-in-bool-context, enabled by default in
> gcc 7, doesn't like multiplication in conditional operators. "Hide" it,
> at the risk of the next compiler version becoming smarter and
> recognizing even that. (The hope is that added smartness then would
> also better deal with legitimate cases like the one here.) The change
> could have been done in access_ok(), but I think we better keep it at
> the place the compiler is actually unhappy about.
I am wondering if we should drop array_access_ok and access_ok as they 
are not used.
Anyway, I am happy with both way:

Reviewed-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel