[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] x86/vpmu: add cpu hot unplug notifier for vpmu

On Thu, 2017-05-18 at 07:16 -0600, Jan Beulich wrote:
> > > > On 18.05.17 at 15:03, <boris.ostrovsky@xxxxxxxxxx> wrote:
> > 
> > As I said last time, I'd rename cpu_callback() to something less
> > generic, like vpmu_cpu_callback() (or vpmu_cpuhp_callback()).
> The vpmu_ prefix is clearly pointless for a static function.
And "just" using cpu_callback is what we do in a lot of (although, not
everywhere :-( ) other places:

xen/common/timer.c:    .notifier_call = cpu_callback,
xen/common/kexec.c:    .notifier_call = cpu_callback
xen/common/cpupool.c:    .notifier_call = cpu_callback
xen/arch/x86/hvm/hvm.c:    .notifier_call = cpu_callback
xen/arch/x86/cpu/mcheck/mce_intel.c:    .notifier_call = cpu_callback
xen/common/stop_machine.c:    .notifier_call = cpu_callback
xen/common/tmem_xen.c:    .notifier_call = cpu_callback
xen/common/tasklet.c:    .notifier_call = cpu_callback,
xen/common/trace.c:    .notifier_call = cpu_callback
xen/drivers/passthrough/io.c:    .notifier_call = cpu_callback,
xen/drivers/cpufreq/cpufreq.c:    .notifier_call = cpu_callback

<<This happens because I choose it to happen!>> (Raistlin Majere)
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.