[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] livepatch/Makefile: Add 'install' stanza

>>> On 17.05.17 at 22:00, <konrad.wilk@xxxxxxxxxx> wrote:
> --- a/xen/test/Makefile
> +++ b/xen/test/Makefile
> @@ -5,3 +5,7 @@ tests:
>  .PHONY: clean
>  clean::
>       $(MAKE) -f $(BASEDIR)/Rules.mk -C livepatch clean
> +
> +.PHONY: install
> +install:
> +     $(MAKE) -f $(BASEDIR)/Rules.mk -C livepatch install

If we really want to provide a standard way to install tests (which
I'm not sure about, after all these are tests and hence play no
role during an actual installation), shouldn't this then at least be
accompanied by a matching uninstall rule?

Also I think if more stuff is to be added here, this Makefile could
do with some abstraction (SUBDIR or subdir-y instead of
explicitly naming the sole current subdirectory) to avoid later
additions needing to touch all this again.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.