[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 6/9] ts-xen-build: Build the livepatch test-cases

On Wed, May 17, 2017 at 08:07:58PM -0400, Konrad Rzeszutek Wilk wrote:
> On Tue, Dec 13, 2016 at 04:49:25PM +0000, Ian Jackson wrote:
> > Konrad Rzeszutek Wilk writes ("[PATCH v2 6/9] ts-xen-build: Build the 
> > livepatch test-cases"):
> > > +    buildcmd_stamped_logged(600, 'xen', 'xenlpt-build', '',<<END,'') if 
> > > $dokconfig;
> > > +        if test -d xen/test; then
> > > +            $make_prefix make -C xen tests
> > > +        fi
> > 
> > Is $dokconfig really the right test for whether the livepatch build
> > should be attempted ?  It seems like a rather arbitrary connection.
> The earlier patch (ts-xen-build: Enable livepatch.) enables the
> correct .config option to make this work. Without that you wouldn't
> be able to enable livepatching.
> And it looks like dokconfig gets changed to zero if --no-kconfig is
> supplied which I presume happens to older Xen versions.


If I do:

 my $ok = buildcmd_stamped_logged(600, 'xen', 'xenlpt-build', '',<<END,'') if 
        $make_prefix make -C xen tests

On older Xen versions (Xen 4.4) I get this:

*** something failed:                                                           
status 256 at Osstest/TestSupport.pm line 444.                                  
** something failed at ./ts-xen-build line 284.                                 

So I feel like the only way to figure out whether the livepatch tests cases
can be built is if I check either the version of Xen (4.9 or above say)
or if an file exists (xen/xen/test/Makefile).

Similar to how ovm_enable or xsm_enable is constructed.
Let me do that.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.