[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.9] x86/pagewalk: Fix determination of Protection Key access rights

Hi Andrew,

On 16/05/17 18:12, Andrew Cooper wrote:
On 16/05/17 18:06, Tim Deegan wrote:
At 17:51 +0100 on 16 May (1494957116), Andrew Cooper wrote:
c/s 4c5d78a10 was accidentally buggy when handling Protection Keys.
Protection keys applies to all user translations, not just accesses which
originate from user mode.
Reviewed-by: Tim Deegan <tim@xxxxxxx>

Does the test for write-protection just below have the opposite bug?
It seems to check whether the page is writable, when AFAICS it should
be checking whether the action is a write (modulo CR0.WP).

Very good point.  Let me draft a v2.

FIY, I will wait the v2 before considering it for the release.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.