Re: [Xen-devel] [PATCH for-4.9] build: stubdom and tools should depend on public header target

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, May 17, 2017 at 02:16:39PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[PATCH for-4.9] build: stubdom and tools should depend on 
> public header target"):
> > Build can fail if stubdom build is run before tools build because:
> > 
> > 1. tools/include build uses relative path and depends on XEN_OS
> > 2. stubdom needs tools/include to be built, at which time XEN_OS is
> >    mini-os and corresponding symlinks are created
> > 3. libraries inside tools needs tools/include to be built, at which
> >    time XEN_OS is the host os name, but symlinks won't be created
> >    because they are already there
> > 4. libraries get the wrong headers and fail to build
> 
> The new code in the Makefiles LGTM.  I have only one nit, which is
> that style for Makefile targets seems to be to use `-' rather than `_'
> as a word separator.

IIRC at one point I used '-' in mini-os build system but some version of
make didn't like it. So I stick with '_' since.

> 
> Anyway,
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 

Sadly this patch is still not enough because other targets of
tools/include are not invoked.

I will send out another patch later.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel