Re: [Xen-devel] [[PATCH]] libxl/arm: Fix ARM build.

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, May 16, 2017 at 06:14:43PM +0300, Andrii Anisov wrote:
> Dear Wei,
> 
> 
> On 16.05.17 14:03, Wei Liu wrote:
> > I'm confused by the commit message.
> 
> My bad, I did not pay enough attention to write the message. Would following
> be better?
> 
>     Implicitly initialize a referenced ouput parameter for all code branches
>     in order to not face a "variable may be used uninitialized" compilation
>     error in a caller function, fired by some compilers under circumstances.
> 
> > If I'm right, would it be better to set *size to 0 in the default
> > branch?
> 
> Agree.
> 

I suspect if you take this approach the commit message you proposed
doesn't quite match either.

Just say:

Initialise *size in default branch to prevent certain compilers (which
ones?) from reporting "variable may be used uninitialized" errors in
caller function.


> -- 
> 
> *Andrii Anisov*
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> https://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel