Re: [Xen-devel] [Qemu-devel] [PATCH RESEND v2 03/21] xen-backend: Remove FIXME comment about user_creatable flag

[Markus Armbruster <armbru@xxxxxxxxxx>]

Stefano or Anthony, please review.

Eduardo Habkost <ehabkost@xxxxxxxxxx> writes:

> xen-backend can be plugged/unplugged dynamically when using the
> Xen accelerator, so keep the user_creatable flag on the device
> class and remove the FIXME comment.
>
> Cc: Juergen Gross <jgross@xxxxxxxx>,
> Cc: Peter Maydell <peter.maydell@xxxxxxxxxx>,
> Cc: Thomas Huth <thuth@xxxxxxxxxx>
> Cc: sstabellini@xxxxxxxxxx
> Cc: Markus Armbruster <armbru@xxxxxxxxxx>,
> Cc: Marcel Apfelbaum <marcel@xxxxxxxxxx>,
> Cc: Laszlo Ersek <lersek@xxxxxxxxxx>
> Acked-by: Juergen Gross <jgross@xxxxxxxx>
> Acked-by: Marcel Apfelbaum <marcel@xxxxxxxxxx>
> Signed-off-by: Eduardo Habkost <ehabkost@xxxxxxxxxx>
> ---
> Changes series v1 -> v2:
> * (New patch added to series)
> ---
>  hw/xen/xen_backend.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c
> index 67cb4cb9f0..2b91d2d458 100644
> --- a/hw/xen/xen_backend.c
> +++ b/hw/xen/xen_backend.c
> @@ -619,10 +619,7 @@ static void xendev_class_init(ObjectClass *klass, void 
> *data)
>  
>      dc->props = xendev_properties;
>      set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> -    /*
> -     * FIXME: Set only because we are not sure yet if this device
> -     * will be outside the q35 sysbus whitelist.
> -     */
> +    /* xen-backend devices can be plugged/unplugged dynamically */
>      dc->user_creatable = true;
>  }

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel