Re: [Xen-devel] [PATCH] include: fix build without C++ compiler installed

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.05.17 at 18:20, <wei.liu2@xxxxxxxxxx> wrote:
> On Fri, May 12, 2017 at 12:52:54AM -0600, Jan Beulich wrote:
>> The rule for headers++.chk wants to move headers++.chk.new to the
>> designated target, which means we have to create that file in the first
>> place.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Thanks.

> If I were to fix it I would just skip the check altogether if CXX isn't
> available. But this approach is fine, too.

I may not be understanding what you mean: The test is being skipped;
the destination file is being touched so that on an incremental re-build
the rule wouldn't be re-run. What else are you imagining? Suppressing
the headers++.chk target altogether would likely be more code churn,
with an overall harder to read Makefile as a result. Yet if you have
something neat and lightweight in mind, I'm all ears (likely for post-4.9
then).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel