[Xen-devel] arm64: incorrect pa setup cause dom0 boot failure

[Feng Kan <fkan@xxxxxxx>]

Ian:

Just a quick question regarding the table below in xen/arch/arm/p2m.c
@@ -1479,7 +1487,7 @@ void __init setup_virt_paging(void)
        [0] = { 32,      32/*32*/,  0,          1 },
        [1] = { 36,      28/*28*/,  0,          1 },
        [2] = { 40,      24/*24*/,  1,          1 },
-        [3] = { 42,      24/*22*/,  1,          1 },
+        [3] = { 42,      22/*22*/,  1,          1 },
^^^ Is this just a typo, or its there for a reason, as I see you made
a comment regarding this later.
We do have a system that PA is 42 bits, so I think that would make the
statement below invalid?
        [4] = { 44,      20/*20*/,  0,          2 },
        [5] = { 48,      16/*16*/,  0,          2 },
        [6] = { 0 }, /* Invalid */


@@ -220,9 +222,11 @@ static lpae_t *p2m_get_root_pointer(struct p2m_domain *p2m,
    root_table = gfn_x(gfn) >> (level_orders[P2M_ROOT_LEVEL - 1]);
    root_table &= LPAE_ENTRY_MASK;

-    if ( root_table >= P2M_ROOT_PAGES )
-        return NULL;
+    //if ( root_table >= P2M_ROOT_PAGES )
+    //    return NULL;
^^^ at least for 42 bit case?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel