Re: [Xen-devel] [PATCH for-4.9] xl: don't ignore return value from libxl_device_events_handler

[Julien Grall <julien.grall@xxxxxxx>]

Hi Wei,

On 11/05/17 13:57, Wei Liu wrote:
> That function can return a whole slew of error codes. Translate them
> to EXIT_FAILURE.
>
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
Release-acked-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

> ---
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Julien Grall <julien.grall@xxxxxxx>
> Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
>  tools/xl/xl_misc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/xl/xl_misc.c b/tools/xl/xl_misc.c
> index 9037e2b2f0..9c6227af23 100644
> --- a/tools/xl/xl_misc.c
> +++ b/tools/xl/xl_misc.c
> @@ -182,7 +182,7 @@ int main_devd(int argc, char **argv)
>          }
>      }
>
> -    libxl_device_events_handler(ctx, 0);
> +    ret = libxl_device_events_handler(ctx, 0) ? EXIT_FAILURE : EXIT_SUCCESS;
>
>  out:
>      return ret;
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel