Re: [Xen-devel] [PATCH v1 10/10] xen/arm: domain_build: Don't expose the "iommus" property to the guest

[Julien Grall <julien.grall@xxxxxxx>]

Hi Oleksandr,

On 10/05/17 15:03, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
>
> We don't passthrough IOMMU device to DOM0 even if it is not used by
> Xen. Therefore exposing the property that describes the IOMMU
> master interfaces of the device does not make any sense.
>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> ---
>  xen/arch/arm/domain_build.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 3abacc0..2defb60 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -432,6 +432,10 @@ static int write_properties(struct domain *d, struct 
> kernel_info *kinfo,
>              continue;
>          }
>
> +        /* Don't expose the property "iommus" to the guest */
> +        if ( dt_property_name_is_equal(prop, "iommus") )
> +            continue;
It would be useful to have a link to the bindings associated 
(Documentation/devicetree/bindings/iommu/iommu.txt).
Also, whilst you are at it, you likely want to remove all the other 
iommu properties such as iommu-map.
> +
>          res = fdt_property(kinfo->fdt, prop->name, prop_data, prop_len);
>
>          if ( res )
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel