[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 08/12 v3] xen/arm: vpl011: Modify xenconsole to support multiple consoles

On Wed, May 10, 2017 at 08:05:14PM +0530, Bhupinder Thakur wrote:
> Xenconsole supports only PV console currently. This patch adds support
> for supporting multiple consoles.
> This patch modifies different data structures and APIs used
> in xenconsole to support multiple consoles.
> Change summary:
> 1. Split the domain structure into a console structure and the
>    domain structure, where each console structure represents one
>    console.
> 2. Modify different APIs such as buffer_append() etc. to take
>    console structure as input and perform per console specific
>    operations.
> 3. Define a generic console_create_ring(), which sets up the
>    ring buffer and event channel for each console.
> 3. Modify domain_create_ring() to use console_create_ring().
> 4. Modifications in handle_ring_read() to read ring buffer data
>    from multiple consoles.
> 5. Add log file support for multiple consoles.

I feel that it would be far easier to review if you spilt this patch
into 5. Can you do that?

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.