Re: [Xen-devel] [PATCH 2/2] libxl/devd: prevent adding spurious domains to the list

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, May 10, 2017 at 11:12:39AM +0100, Roger Pau Monne wrote:
> Current code in backend_watch_callback forgets to remove a 
> libxl__ddomain_guest
> from the list of tracked domains when the related data is freed, causing
> dereferences later on when the list is traversed. Make sure that a domain is
> always removed from the list when freed.

There is another bug: dguest was freed by a spurious event. That is also
fixed by this patch.

I would suggest changing the tite to "correctly manipulate the dguest
list" and also extend the commit message to include that other bug.

Code-wise:

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel