Re: [Xen-devel] [PATCH for-next] x86/mtrr: Improvements to control register handling

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.05.17 at 12:45, <andrew.cooper3@xxxxxxxxxx> wrote:
> Use X86_CR0_CD rather than opencoding it (and its inversion).  Drop the
> pointless cr0 variable.
> 
> Xen always uses CR4.PGE, and altering PGE is a full TLB flush.  There is no
> need to call flush_tlb_local() (which itself, toggles CR4.PGE rather than
> writing to CR3!) as well as clearing CR4.PGE.  The static cr4 variable isn't
> needed either.

Yeah, this all looks like leftovers from the 32-bit days (and perhaps
even from the 32-bit-only ones).

> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel