Re: [Xen-devel] [PATCH]acpi: enlarge NUM_FIXMAP_ACPI_PAGES from 4 to 5

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.05.17 at 04:59, <oscar.zhangbo@xxxxxxxxxx> wrote:
> --- a/xen/include/xen/acpi.h
> +++ b/xen/include/xen/acpi.h
> @@ -43,7 +43,7 @@
>   * Fixmap pages to reserve for ACPI boot-time tables (see asm-x86/fixmap.h or
>   * asm-arm/config.h)
>   */
> -#define NUM_FIXMAP_ACPI_PAGES  4
> +#define NUM_FIXMAP_ACPI_PAGES  5

Well, this is the kind of fix I don't really like: You make things work for
you without thinking about others. If you found 4 pages aren't
enough, how likely is it that soon someone will find 5 aren't enough
either? IOW, short of eliminating the fixed upper bound altogether,
you should at least add some slack for the foreseeable future. For
this it may also help to estimate the theoretical upper limit of SRAT
(and perhaps other affected tables) for systems currently around
plus, again, some slack. As you may have concluded already it
would therefore also have helped if you had indicated what size a
system you see this relatively large SRAT on.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel