[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC PATCH v2 06/25] x86: NUMA: Add accessors for nodes[] and node_memblk_range[] structs

On 05/09/2017 08:02 AM, Vijay Kilari wrote:
On Mon, May 8, 2017 at 8:09 PM, Julien Grall <julien.grall@xxxxxxx> wrote:
Hi Vijay,

On 28/03/17 16:53, vijay.kilari@xxxxxxxxx wrote:

From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxx>

Add accessor for nodes[] and other static variables and


used those accessors.

Also, I am not sure to understand the usefulness of those accessors over a
global variable.

These are static variables which needs to accessed from other files and
later moved to generic file.

101 of a contributor, always explaining in the commit message why you do something. Also, I am quite confused why sometimes you decide to use static and helper, other time you will use global variables.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.