Re: [Xen-devel] [PATCH v3] x86: correct create_bounce_frame

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 05/05/17 15:41, Andrew Cooper wrote:
> On 05/05/17 14:11, Jan Beulich wrote:
> > Commit d9b7ef209a7 ("x86: drop failsafe callback invocation from
> > assembly") didn't go quite far enough with the cleanup it did: The
> > changed maximum frame size should also have been reflected in the early
> > address range check (which has now been pointed out to have been wrong
> > anyway, using 60 instead of 0x60), and it should have updated the
> > comment ahead of the function.
> >
> > Also adjust the lower bound - all is fine (for our purposes) if the
> > initial guest kernel stack pointer points right at the hypervisor base
> > address, as only memory _below_ that address is going to be written.
> >
> > Additionally limit the number of times %rsi is being adjusted to what
> > is really needed.
> >
> > Finally move exception fixup code into the designated .fixup section
> > and macroize the stores to guest stack.
> >
> > Reported-by: Jann Horn <jannh@xxxxxxxxxx>
> > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Release-acked-by: Julien grall <julien.grall@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel