Re: [Xen-devel] [PATCH for-next] x86/mm: Correctly indent the pin_page block of do_mmuext_op()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.05.17 at 17:51, <andrew.cooper3@xxxxxxxxxx> wrote:
> The pin_page block is missing one level of indentation, which makes the
> MMUEXT_UNPIN_TABLE case label appear to be outside of the switch statement.
> 
> While making this adjustment, delete one other piece of trailing whitespace.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

May I suggest to do this with much less code churn? If you make
the "page" local variable switch-wide (which the unpin code then
can also benefit from, as could the clear-page one) you won't
need to re-indent anything.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel