Re: [Xen-devel] [PATCH v3 3/9] mm: Scrub pages in alloc_heap_pages() if needed

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.05.17 at 17:04, <boris.ostrovsky@xxxxxxxxxx> wrote:
> On 05/04/2017 10:44 AM, Jan Beulich wrote:
>>>>> On 14.04.17 at 17:37, <boris.ostrovsky@xxxxxxxxxx> wrote:
>>> When allocating pages in alloc_heap_pages() first look for clean pages.
>> As expressed before, there are cases when we don't really need
>> scrubbed pages. Hence the local variable "use_unscrubbed" below
>> should really be some form of input to alloc_heap_pages().
> 
> That would be alloc_xenheap_pages() only, in which case can I just
> initialize the still local use_unscrubbed
> as
>     use_unscrubbed = (zone_lo == MEMZONE_XEN)
> 
> Or do you prefer this to be explicit?

I'd be fine with this implicit variant if it was correct, but I think it's
correct only for the CONFIG_SEPARATE_XENHEAP case.
Furthermore alloc_domheap_pages(NULL, ...) also doesn't
require scrubbed pages to be returned.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel