[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] X86/vmx: Dump PIR and vIRR before ASSERT()

>>> On 04.05.17 at 11:47, <julien.grall@xxxxxxx> wrote:
> On 14/02/17 10:51, Jan Beulich wrote:
>>>>> On 07.02.17 at 00:32, <chao.gao@xxxxxxxxx> wrote:
>>> Commit c7bdecae42 ("x86/apicv: fix RTC periodic timer and apicv issue") has
>>> added a assertion that intack.vector is the highest priority vector. But
>>> according to the osstest, the assertion failed sometimes. More discussion 
>>> can
>>> be found in the thread
>>> (https://lists.xenproject.org/archives/html/xen-devel/2017-01/msg01019.html).
>>> The assertion failure is hard to reproduce. In order to root cause issue, 
>>> this
>>> patch is to add logs to dump PIR and vIRR when failure takes place. It 
>>> should
>>> be reverted once the root cause is found.
>> Julien, could you add a note on the 4.9 tracking list for us to not
>> forget to revert this (or at least add NDEBUG conditionals) the
>> latest in the RC phase?
> Bumping this discussion as we are in the RC phase. Was the root cause 
> found and we can revert the patch?

Sadly not, so far.

> Or shall we surround the code with NDEBUG?

Yes, I'll submit a patch.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.