Re: [Xen-devel] [PATCH] x86/mm: add temporary debugging code to get_page_from_gfn_p2m()

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 04/05/17 10:39, Andrew Cooper wrote:
> On 04/05/17 10:09, Jan Beulich wrote:
> > See the code comment.
> >
> > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Release-acked-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

> > --- a/xen/arch/x86/mm/p2m.c
> > +++ b/xen/arch/x86/mm/p2m.c
> > @@ -480,6 +480,22 @@ struct page_info *get_page_from_gfn_p2m(
> >      p2m_access_t _a;
> >      p2m_type_t _t;
> >      mfn_t mfn;
> > +#ifndef NDEBUG
> > +    /*
> > +     * Temporary debugging code, added in the hope of finding the origin
> > +     * of calls to get_page(..., dom_cow) as observed during osstest
> > +     * migration failures (see
> > +     * lists.xenproject.org/archives/html/xen-devel/2017-04/msg03331.html).
> > +     */
> > +    static unsigned long cnt, thr;
> > +
> > +    if ( d->is_dying && ++cnt > thr )
> > +    {
> > +        thr |= cnt;
> > +        printk("%pv: d%d dying (looking up %lx)\n", current, d->domain_id, 
> > gfn);
> > +        dump_execution_state();
> > +    }
> > +#endif
> >
> >      /* Allow t or a to be NULL */
> >      t = t ?: &_t;
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel