Re: [Xen-devel] [PATCH 1/7] x86/traps: Drop 32bit fields out of tss_struct

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 03/05/17 09:10, Jan Beulich wrote:
>>>> On 02.05.17 at 20:05, <andrew.cooper3@xxxxxxxxxx> wrote:
>> The backlink field doesn't exist in a 64bit TSS, and union for esp{0..2} is 
>> of
>> no practical use.  Specify everything with stdint types, and empty bitfields
>> for reserved values.
>>
>> No functional change.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> with one minor extra adjustment:
>
>> --- a/xen/arch/x86/traps.c
>> +++ b/xen/arch/x86/traps.c
>> @@ -461,7 +461,7 @@ void show_stack_overflow(unsigned int cpu, const struct 
>> cpu_user_regs *regs)
>>  
>>      printk("Valid stack range: %p-%p, sp=%p, tss.esp0=%p\n",
> Would you mind dropping or replacing the e in esp0 here too?

Fixed.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel