Re: [Xen-devel] [PATCH 00/10] pl011 emulation support in Xen

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Wed, 26 Apr 2017, Bhupinder Thakur wrote:
> Hi Julien,
> 
> 
> >>  tools/console/client/main.c      |   6 +
> >>  tools/console/daemon/io.c        | 532
> >> +++++++++++++++++++++++++++------------
> >>  tools/libxc/include/xc_dom.h     |   3 +
> >>  tools/libxc/xc_dom_arm.c         |   7 +-
> >>  tools/libxc/xc_dom_boot.c        |   3 +
> >>  tools/libxc/xc_domain.c          |   7 +
> >>  tools/libxl/libxl.c              |  10 +
> >>  tools/libxl/libxl_arm.c          |  48 +++-
> >>  tools/libxl/libxl_create.c       |  12 +
> >>  tools/libxl/libxl_dom.c          |  13 +-
> >>  tools/libxl/libxl_internal.h     |   5 +
> >>  tools/libxl/libxl_types.idl      |   2 +
> >>  tools/libxl/xl_cmdimpl.c         |   4 +
> >>  xen/arch/arm/Kconfig             |   5 +
> >>  xen/arch/arm/Makefile            |   1 +
> >>  xen/arch/arm/domain.c            |  11 +
> >>  xen/arch/arm/hvm.c               | 112 +++++++++
> >>  xen/arch/arm/vpl011.c            | 339 +++++++++++++++++++++++++
> >>  xen/common/domctl.c              |   3 +
> >>  xen/include/asm-arm/domain.h     |   5 +
> >>  xen/include/asm-arm/pl011-uart.h |   2 +
> >>  xen/include/public/arch-arm.h    |   8 +
> >>  xen/include/public/domctl.h      |   2 +
> >>  xen/include/public/hvm/params.h  |  10 +
> >>  xen/include/xen/sched.h          |   4 +
> >>  xen/include/xen/vpl011.h         |  67 +++++
> >
> >
> > I was expecting an update of the documentation for the new options
> > introduced and the expected behavior for IRQ numbering when using both pl011
> > and assign physical IRQ.
> >
> > Please add the documentation in the next version.
> >
> I have added details on the vuart console option in docs/misc/console.txt.
> 
> I have added a check that if user tries to allocate a physical IRQ
> which is same as the pl011 SPI then domain creation would fail. Is
> there any IRQ specific document where I can add this behavior?

I don't think so. Maybe you could add an line about this to the xl.cfg
man page under the irqs= section?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel