[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [RFC PATCH v2 04/25] x86: NUMA: Add accessors for acpi_numa, numa_off and numa_fake variables
>>> On 25.04.17 at 17:14, <julien.grall@xxxxxxx> wrote: > On 25/04/17 15:54, Vijay Kilari wrote: >> On Tue, Apr 25, 2017 at 5:58 PM, Julien Grall <julien.grall@xxxxxxx> wrote: >>>>>> >>>>>> By setting 1, we are enabling acpi_numa by default. If not enabled, the >>>>>> below >>>>>> call has check srat_disabled() before proceeding fails. >>>>> >>>>> >>>>> >>>>> My understanding is on x86 acpi_numa is disabled by default and will be >>>>> enabled if they are able to parse the SRAT. So why are you changing the >>>>> behavior for x86? >>>> >>>> >>>> acpi_numa = 0 means it is enabled by default on x86. >>> >>> >>> In acpi_scan_nodes: >>> >>> if (acpi_numa <= 0) >>> return -1; >>> >>> So it does not seem that 0 means enabled. >> >> IMO, In x86 >> -1 means disabled >> 0 enabled but not numa initialized >> 1 enabled and numa initialized. >> >> I clubbed 0 & 1. > > From your description 0 and 1 have different meaning, so I don't see > how you can merge them that easily without any explanation. > > Anyway, I will leave x86 maintainers give their opinion here. I'm pretty certain this needs to remain a tristate. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |