[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH for-next v2 02/10] x86/domain: provide pv_{create, destroy}_gdt_ldt_l1tab and use them
On Tue, Apr 25, 2017 at 02:56:01PM +0100, Andrew Cooper wrote: > On 25/04/17 14:52, Wei Liu wrote: > > This patch encapsulates the perdomain creation and destruction into > > helper functions and use them where appropriate. > > > > Since destroy_perdomain_mapping is idempotent, it is safe to call the > > destruction function multiple times. > > > > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx> > > --- > > Cc: Jan Beulich <jbeulich@xxxxxxxx> > > Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> > > --- > > xen/arch/x86/domain.c | 23 ++++++++++++++++++++--- > > 1 file changed, 20 insertions(+), 3 deletions(-) > > > > diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c > > index 90e2b1f82a..1f76d034a7 100644 > > --- a/xen/arch/x86/domain.c > > +++ b/xen/arch/x86/domain.c > > @@ -387,6 +387,18 @@ int switch_compat(struct domain *d) > > return rc; > > } > > > > +static int pv_create_gdt_ldt_l1tab(struct domain *d, struct vcpu *v) > > +{ > > + return create_perdomain_mapping(d, GDT_VIRT_START(v), > > + 1 << GDT_LDT_VCPU_SHIFT, > > + d->arch.pv_domain.gdt_ldt_l1tab, NULL); > > +} > > + > > +static void pv_destroy_gdt_ldt_l1tab(struct domain *d, struct vcpu *v) > > +{ > > + destroy_perdomain_mapping(d, GDT_VIRT_START(v), 1 << > > GDT_LDT_VCPU_SHIFT); > > +} > > What is the point of passing both d and v? Isn't d always v->domain ? > Yes you're right. > Otherwise, LGTM. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |