Re: [Xen-devel] [PATCH v2 for-next v2 6/8] x86/mm: move two PV hypercalls from x86_64/mm.c to pv/mm.c

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Apr 19, 2017 at 09:33:28AM -0600, Jan Beulich wrote:
> >>> On 03.04.17 at 13:22, <wei.liu2@xxxxxxxxxx> wrote:
> > --- a/xen/arch/x86/pv/mm.c
> > +++ b/xen/arch/x86/pv/mm.c
> > @@ -4106,6 +4106,74 @@ int mmio_ro_do_page_fault(struct vcpu *v, unsigned 
> > long addr,
> 
> Considering this file is still 4k lines, I'd prefer if stuff not obviously
> belonging here could be placed elsewhere.
> 

Looking back to previous patch's commit message, I can split this file
into more files: two or three for emulation code, one for grant table
code, one or two for hypercalls.

Would that be ok for you? If yes, do you have preferences for file
names?

Wei.

> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel