Re: [Xen-devel] [PATCH for-next 2/7] x86: move x86_64/compat/entry.S to pv/compat

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 21/04/17 10:16, Jan Beulich wrote:
>>>> On 06.04.17 at 19:14, <wei.liu2@xxxxxxxxxx> wrote:
>> That file contains 32 bit PV guest entry points.
>>
>> No functional change.
>>
>> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
>> ---
>>  xen/arch/x86/pv/Makefile                    | 2 ++
>>  xen/arch/x86/{x86_64 => pv}/compat/Makefile | 0
>>  xen/arch/x86/{x86_64 => pv}/compat/entry.S  | 0
> While this one indeed looks fine to be moved as a whole, I'm not
> convinced we want to retain this compat/ subdirectory level, as
> we don't really have CONFIG_COMPAT anymore anyway (there
> are only very few leftovers in x86-specific code, and it looks like
> they've been wrongly re-introduced not so long ago). I.e. I'd
> rather see this being merged into pv/entry.S.

We most certainly do have CONFIG_COMPAT (and it is used), but I also
want to get rid of the compat/ directories.

+1 for pv/entry.S (or alternatively to follow the Linux model and using
entry_64.S and entry_64_compat.S.  I guess it depends how much code we
end up having which is guest-type specific, once I have finished moving
all I reasonably can up into C.)

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel