[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [Qemu-devel] [PATCH v2] event: Add source information to SHUTDOWN
- To: "Daniel P. Berrange" <berrange@xxxxxxxxxx>, Markus Armbruster <armbru@xxxxxxxxxx>
- From: Eric Blake <eblake@xxxxxxxxxx>
- Date: Thu, 20 Apr 2017 08:20:11 -0500
- Cc: Peter Maydell <peter.maydell@xxxxxxxxxx>, "open list:Overall" <kvm@xxxxxxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Mark Cave-Ayland <mark.cave-ayland@xxxxxxxxxxxx>, qemu-devel@xxxxxxxxxx, Scott Wood <scottwood@xxxxxxxxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>, "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxx>, Rob Herring <robh@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Magnus Damm <magnus.damm@xxxxxxxxx>, Alexander Graf <agraf@xxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, "open list:X86" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Richard Henderson <rth@xxxxxxxxxxx>, Artyom Tarasenko <atar4qemu@xxxxxxxxx>, Eduardo Habkost <ehabkost@xxxxxxxxxx>, Stefan Weil <sw@xxxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxxxxx>, "open list:Calxeda Highbank" <qemu-arm@xxxxxxxxxx>, Jan Kiszka <jan.kiszka@xxxxxx>, Igor Mammedov <imammedo@xxxxxxxxxx>, Cornelia Huck <cornelia.huck@xxxxxxxxxx>, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>, Paul Burton <paul.burton@xxxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, Marcelo Tosatti <mtosatti@xxxxxxxxxx>, Michael Walle <michael@xxxxxxxx>, "open list:New World" <qemu-ppc@xxxxxxxxxx>, Yongbok Kim <yongbok.kim@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Aurelien Jarno <aurelien@xxxxxxxxxxx>
- Delivery-date: Thu, 20 Apr 2017 13:20:33 +0000
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com D1695C03BD62
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D1695C03BD62
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
- Openpgp: url=http://people.redhat.com/eblake/eblake.gpg
On 04/20/2017 07:09 AM, Daniel P. Berrange wrote:
>>> +++ b/qapi/event.json
>>> @@ -10,6 +10,10 @@
>>> # Emitted when the virtual machine has shut down, indicating that qemu is
>>> # about to exit.
>>> #
>>> +# @guest: If true, the shutdown was triggered by a guest request (such as
>>> +# executing a halt instruction) rather than a host request (such as sending
>>> +# qemu a SIGINT). (since 2.10)
>>> +#
>>
>> "executing a halt instruction" suggests "halt" is a machine instruction.
Which is indeed what most of the places I patched to pass 'true' are
emulating - the machine halt instruction.
>> I think you mean /usr/sbin/halt. Suggest something like "executing a
>> halt command".
>
> Well technically /usr/sbin/halt just terminates all processes / kernel and
> halts CPUs, but the virtual machine is still active (and a 'reset' in the
> monitor can start it again. /usr/sbin/poweroff is what actually does the
> ACPI poweroff to trigger QEMU to exit[1]
I'm thinking of this wording:
triggered by a guest request (such as the guest running
/usr/sbin/poweroff to trigger an ACPI shutdown or machine halt instruction)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
