Re: [Xen-devel] [PATCH v4 2/2] kexec: remove spinlock now that all KEXEC hypercall ops are protected at the top-level

[Daniel Kiper <daniel.kiper@xxxxxxxxxx>]

On Thu, Apr 20, 2017 at 01:14:30PM +0100, Andrew Cooper wrote:
> On 20/04/17 11:46, Jan Beulich wrote:
> >>>> On 19.04.17 at 23:01, <eric.devolder@xxxxxxxxxx> wrote:
> >> The spinlock in kexec_swap_images() was removed as
> >> this function is only reachable on the kexec hypercall, which is
> >> now protected at the top-level in do_kexec_op_internal(),
> >> thus the local spinlock is no longer necessary.
> >>
> >> Per recommendation from Jan Beulich and Andrew Cooper, I left
> >> an ASSERT in place of the spin_lock().
> >>
> >> Signed-off-by: Eric DeVolder <eric.devolder@xxxxxxxxxx>
> >> Reviewed-by: Bhavesh Davda <bhavesh.davda@xxxxxxxxxx>
> >> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel