Re: [Xen-devel] [PATCH v3 2/2] kexec: remove spinlock now that all KEXEC hypercall ops are protected at the top-level

[Eric DeVolder <eric.devolder@xxxxxxxxxx>]

On 04/19/2017 11:21 AM, Jan Beulich wrote:
> > > > On 19.04.17 at 17:47, <eric.devolder@xxxxxxxxxx> wrote:
> > @@ -832,7 +831,7 @@ static int kexec_swap_images(int type, struct kexec_image 
> > *new,
> >      if ( kexec_load_get_bits(type, &base, &bit) )
> >          return -EINVAL;
> >
> > -    spin_lock(&kexec_lock);
> > +    ASSERT( !test_bit(KEXEC_FLAG_IN_HYPERCALL, &kexec_flags) );
> Did you test this (in a debug build)? I ask because it looks to me that
> you've inverted the condition.
You are correct, I inverted the condition. I had found this shortly 
after posting, and have corrected and have tested with Config.mk:debug=y
I will repost patch.

Thanks,
eric



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel