Re: [Xen-devel] [PATCH 01/10] xen/arm: vpl011: Add pl011 uart emulation in Xen

[Julien Grall <julien.grall@xxxxxxx>]

Hi Bhupinder,

On 04/19/2017 08:28 AM, Bhupinder Thakur wrote:
> On 19 April 2017 at 05:45, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
> > > +    }
> > > +}
> > > +
> > > +
> > > +static void vpl011_notification(struct vcpu *v, unsigned int port)
> > > +{
> > > +    vpl011_data_avail(v->domain);
> > > +}
> > > +
> > > +int domain_vpl011_init(struct domain *d, struct xen_arch_domainconfig *config)
> > > +{
> > > +    int rc;
> > > +    struct vpl011_s *vpl011 = &d->arch.vpl011;
> > > +
> > > +    rc = alloc_unbound_xen_event_channel(d, 0, config->console_domid,
> > > +                                         vpl011_notification);
> > > +    if (rc < 0)
> > > +    {
> > > +        return rc;
> > > +    }
> > > +    d->arch.hvm_domain.params[HVM_PARAM_VCONSOLE_EVTCHN] = rc;
> > > +    rc = vgic_reserve_virq(d, GUEST_VPL011_SPI);
> > > +    if ( !rc )
> > > +        return rc;
> > We should free the allocated evtchn in case of error here
> I will free the event channel.
You will also want to reset d->arch.hvm_domain.params[...] to avoid the 
the other end reading garbage.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel