Re: [Xen-devel] [PATCH RFC] handle tsc_tolerance during migration between identical hosts

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.04.17 at 09:46, <olaf@xxxxxxxxx> wrote:
> On Tue, Apr 18, Jan Beulich wrote:
> 
>> >>> On 18.04.17 at 11:50, <olaf@xxxxxxxxx> wrote:
>> > On Tue, Apr 11, Jan Beulich wrote:
>> > 
>> >> I'm afraid successful testing is not a sufficient criteria here. At
>> >> the very least the (so far missing) documentation needs to very
>> >> clearly point out the possible risks associated with using this
>> >> option. But with there not being any functional change when
>> >> the option is not being made use of, I don't think there's a
>> >> reason not to add this (for the adventurous).
>> > 
>> > This can be handled by refering to the documentation of
>> > 'tsc_mode=native', which is what this change actually does.
>> 
>> Does it? I've just looked at th patch again, and I didn't find any
>> such referral. Are you perhaps talking about some change you
>> only have done locally?
> 
> To me it looks like ->vtsc decides if there is emulation or not. So in
> this sense tsc_mode remains "native" if the khz value is within the
> tolerance range.

How does that answer my question? I still don't see any referral
to documentation (or another prominent warning about the risks
associated with the use of that new option).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel